[Precogs AI - Fix] Buffer Overflow / NULL Dereference from unsafe fgets handling (Critical) in Employee-Management-System/Employee Management System-github.c#2
Open
sameer6pre wants to merge 1 commit intomasterfrom
Conversation
… in branch precogs/auto-fix/critical-1774610294168
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Precogs Auto-Fix
Vulnerability: Buffer Overflow / NULL Dereference from unsafe fgets handling
Severity: Critical
File:
Employee-Management-System/Employee Management System-github.cCWE: CWE-119
What was fixed
The code repeatedly calls fgets(...) to read user input into fixed-size char arrays and immediately unconditionally does e.field[strlen(e.field)-1] = '\0'. This assumes fgets returned a non-NULL pointer and that the buffer contains at least one character (typically a trailing newline). If fgets returns NULL (EOF or error) the subsequent strlen dereferences NULL (crash). If the input fills the buffer exactly (no newline), removing the last character blindly may remove valid data. If an attacker can control input they can cause undefined behavior, memory corruption, or crashes. Using fflush(stdin) before fgets is undefined behavior and doesn't reliably clear input on all platforms.
This PR was automatically generated by Precogs AI. Review the changes before merging.