Skip to content

[Precogs Alert] Buffer Overflow / NULL Dereference from unsafe fgets handling detected (CWE-119, Risk: Critical)#5

Open
sameer6pre wants to merge 1 commit intomasterfrom
Precogs-fix-jf1cysu9
Open

[Precogs Alert] Buffer Overflow / NULL Dereference from unsafe fgets handling detected (CWE-119, Risk: Critical)#5
sameer6pre wants to merge 1 commit intomasterfrom
Precogs-fix-jf1cysu9

Conversation

@sameer6pre
Copy link
Copy Markdown
Owner

Vulnerability Details

  • File Path: Employee-Management-System/Employee Management System-github.c
  • Vulnerability Type: Buffer Overflow / NULL Dereference from unsafe fgets handling
  • Risk Level: Critical

Explanation:
The code repeatedly calls fgets(...) to read user input into fixed-size char arrays and immediately unconditionally does e.field[strlen(e.field)-1] = '\0'. This assumes fgets returned a non-NULL pointer and that the buffer contains at least one character (typically a trailing newline). If fgets returns NULL (EOF or error) the subsequent strlen dereferences NULL (crash). If the input fills the buffer exactly (no newline), removing the last character blindly may remove valid data. If an attacker can control input they can cause undefined behavior, memory corruption, or crashes. Using fflush(stdin) before fgets is undefined behavior and doesn't reliably clear input on all platforms.

Please review and address the issue accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant