Skip to content

[Precogs AI - Fix] OS Command Injection (Critical) in sample-vuln/app.py #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sameer6pre wants to merge 2 commits into
base: Precogs-fix-5kqi2b08
Choose a base branch
from
Open

[Precogs AI - Fix] OS Command Injection (Critical) in sample-vuln/app.py #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bd120e2
Update sample-vuln/app.py in branch precogs/auto-fix/critical-1774611…
sameer6pre Mar 27, 2026
1191e88
Update README.md
sameer6pre Apr 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,3 +3,4 @@ jh
cdsav
kjhbvljhv
wfewqfd
acWDSCV
21 changes: 21 additions & 0 deletions sample-vuln/app.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@

@app.route("/ping")
from flask import request

@app.route("/ping")
def ping():
ip = request.args.get("ip", "127.0.0.1")
import ipaddress, subprocess
try:
# PRECOGS_FIX: validate the IP address strictly using ipaddress
ip_obj = ipaddress.ip_address(ip)
except Exception:
return {"error": "invalid ip"}, 400

# PRECOGS_FIX: call ping without invoking a shell, pass arguments as a list
try:
subprocess.run(["ping", "-c", "1", str(ip_obj)], check=False)
except FileNotFoundError:
return {"error": "ping command not available"}, 500

return {"status": "ok"}