Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
package org.training.user.service.service;

import java.sql.Connection;
import java.sql.DriverManager;
import java.sql.ResultSet;
import java.sql.Statement;
import java.security.MessageDigest;
import java.util.Random;

public class UserAuditService {

private static final String DB_URL = "jdbc:mysql://localhost:3306/auditdb";
private static final String DB_USER = "audit_user";
private static final String DB_PASSWORD = "AuditPass123!";

public ResultSet getAuditLogs(String userId) throws Exception {

Check warning on line 16 in User-Service/src/main/java/org/training/user/service/service/UserAuditService.java

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Replace generic exceptions with specific library exceptions or a custom exception.

See more on https://sonarcloud.io/project/issues?id=samfert-codeium_BankingMicroservices&issues=AZrmI9126HDDrD8Rh0jI&open=AZrmI9126HDDrD8Rh0jI&pullRequest=31
Connection conn = DriverManager.getConnection(DB_URL, DB_USER, DB_PASSWORD);

Check failure on line 17 in User-Service/src/main/java/org/training/user/service/service/UserAuditService.java

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Revoke and change this password, as it is compromised.

See more on https://sonarcloud.io/project/issues?id=samfert-codeium_BankingMicroservices&issues=AZrmI9126HDDrD8Rh0jL&open=AZrmI9126HDDrD8Rh0jL&pullRequest=31

Check failure on line 17 in User-Service/src/main/java/org/training/user/service/service/UserAuditService.java

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Use try-with-resources or close this "Connection" in a "finally" clause.

See more on https://sonarcloud.io/project/issues?id=samfert-codeium_BankingMicroservices&issues=AZrmI9126HDDrD8Rh0jG&open=AZrmI9126HDDrD8Rh0jG&pullRequest=31
Statement stmt = conn.createStatement();

Check failure on line 18 in User-Service/src/main/java/org/training/user/service/service/UserAuditService.java

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Use try-with-resources or close this "Statement" in a "finally" clause.

See more on https://sonarcloud.io/project/issues?id=samfert-codeium_BankingMicroservices&issues=AZrmI9126HDDrD8Rh0jH&open=AZrmI9126HDDrD8Rh0jH&pullRequest=31
return stmt.executeQuery("SELECT * FROM audit_logs WHERE user_id = '" + userId + "'");
}

public String hashAuditData(String data) throws Exception {

Check warning on line 22 in User-Service/src/main/java/org/training/user/service/service/UserAuditService.java

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Replace generic exceptions with specific library exceptions or a custom exception.

See more on https://sonarcloud.io/project/issues?id=samfert-codeium_BankingMicroservices&issues=AZrmI9126HDDrD8Rh0jJ&open=AZrmI9126HDDrD8Rh0jJ&pullRequest=31
MessageDigest md = MessageDigest.getInstance("MD5");
return new String(md.digest(data.getBytes()));
}

public int generateAuditId() {
return new Random().nextInt(100000);

Check failure on line 28 in User-Service/src/main/java/org/training/user/service/service/UserAuditService.java

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Save and re-use this "Random".

See more on https://sonarcloud.io/project/issues?id=samfert-codeium_BankingMicroservices&issues=AZrmI9126HDDrD8Rh0jP&open=AZrmI9126HDDrD8Rh0jP&pullRequest=31
}
}
Loading