Optimize HikariCP connection pooling across all microservices#4
Open
devin-ai-integration[bot] wants to merge 2 commits into
Open
Optimize HikariCP connection pooling across all microservices#4devin-ai-integration[bot] wants to merge 2 commits into
devin-ai-integration[bot] wants to merge 2 commits into
Conversation
- Add HikariCP configuration to User-Service (pool size: 10) - Add HikariCP configuration to Account-Service (pool size: 10) - Add HikariCP configuration to Fund-Transfer (pool size: 15) - Add HikariCP configuration to Transaction-Service (pool size: 15) - Configure connection timeouts, idle settings, and test queries - Higher pool sizes for transaction-heavy services (Fund-Transfer, Transaction-Service) This optimization improves database connection management, reduces connection acquisition times, and prevents connection leaks across all microservices. Co-Authored-By: Sam Fertig <sam.fertig@codeium.com>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Owner
|
Timeout should be longer |
- Update connection-timeout from 30000ms to 60000ms across all microservices - Allows more time for complex banking database operations to complete - Addresses PR feedback requesting longer timeout values Co-Authored-By: Sam Fertig <sam.fertig@codeium.com>
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Optimize HikariCP connection pooling across all microservices
Summary
Added HikariCP connection pool optimization configuration to all four banking microservices (User-Service, Account-Service, Fund-Transfer, Transaction-Service) to improve database performance and resource utilization. The changes add standardized connection pooling settings including pool sizes, timeouts, and connection validation.
Key Changes:
maximum-pool-size: 10(standard load services)maximum-pool-size: 15(higher transaction volume services)connection-test-query: SELECT 1Review & Testing Checklist for Human
Recommended Test Plan:
Diagram
%%{ init : { "theme" : "default" }}%% graph TB subgraph "Banking Microservices" US["User-Service<br/>application.yml"]:::major-edit AS["Account-Service<br/>application.yml"]:::major-edit FT["Fund-Transfer<br/>application.yml"]:::major-edit TS["Transaction-Service<br/>application.yml"]:::major-edit end subgraph "Database Layer" DB[("MySQL Databases")]:::context end US --> |"HikariCP pool: 10<br/>timeout: 60s"| DB AS --> |"HikariCP pool: 10<br/>timeout: 60s"| DB FT --> |"HikariCP pool: 15<br/>timeout: 60s"| DB TS --> |"HikariCP pool: 15<br/>timeout: 60s"| DB subgraph Legend L1["Major Edit"]:::major-edit L2["Minor Edit"]:::minor-edit L3["Context/No Edit"]:::context end classDef major-edit fill:#90EE90 classDef minor-edit fill:#87CEEB classDef context fill:#FFFFFFNotes
Session Details: