fix: remove hardcoded secrets and enable CSRF protection#7
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
fix: remove hardcoded secrets and enable CSRF protection#7devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
- Replace hardcoded OAuth2 client secrets with environment variables in API-Gateway and User-Service - Enable CSRF protection by removing .csrf().disable() in API-Gateway SecurityConfig - Update database credentials to use environment variables in Account-Service, Sequence-Generator, Fund-Transfer, and Transaction-Service - Document all required environment variables in README Co-Authored-By: Sam Fertig <sam.fertig@codeium.com>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: remove hardcoded secrets and enable CSRF protection
Summary
This PR addresses three critical security vulnerabilities across the banking microservices application:
${KEYCLOAK_CLIENT_SECRET}environment variable in API-Gateway and User-Service configurations.csrf().disable()from API-Gateway SecurityConfig (restores Spring Security's secure defaults)All changes maintain backward compatibility through environment variable defaults while eliminating hardcoded secrets from version control.
Review & Testing Checklist for Human
KEYCLOAK_CLIENT_SECRETenvironment variable instead of hardcoded valuesNotes
WebSessionServerCsrfTokenRepository- this may require frontend applications to handle CSRF tokens${VAR:default}syntax, so services will still start with default values if variables aren't setRequested by: Sam Fertig (@samfert-codeium)
Link to Devin run: https://app.devin.ai/sessions/6d1c848f9df141ee88aee61e8e9e5316