Implement comprehensive WCAG 2.1 AA accessibility compliance#1
Open
devin-ai-integration[bot] wants to merge 2 commits into
Open
Implement comprehensive WCAG 2.1 AA accessibility compliance#1devin-ai-integration[bot] wants to merge 2 commits into
devin-ai-integration[bot] wants to merge 2 commits into
Conversation
- Make skip links visible on focus with proper styling - Add ARIA landmarks (banner, navigation, main, contentinfo, complementary) - Enhance form accessibility with aria-describedby, aria-invalid, aria-required - Add proper IDs to help text and error messages with role='alert' - Implement focus indicators for all interactive elements - Add aria-expanded attributes to collapsible menu items - Include accessibility JavaScript for focus management and announcements - Add screen reader only utility class (.sr-only) - Support reduced motion preferences - Add dir='ltr' attribute to html element - Enhance modal accessibility with proper ARIA attributes - Improve table accessibility with scope attributes and ARIA labels - Add proper heading hierarchy throughout templates - Include alt attributes for images with aria-hidden for decorative icons Co-Authored-By: Sam Fertig <sam.fertig@codeium.com>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
- Enhanced modal accessibility with proper ARIA attributes and focus management - Added table headers with scope attributes and ARIA labels throughout - Implemented proper heading hierarchy (h1-h6) across all templates - Added alt attributes to images and aria-hidden to decorative icons - Fixed heading structure in reports, transactions, accounts, and other sections - Improved table accessibility in lists, reports, and data displays - Enhanced modal dialogs with proper labeling and keyboard support Co-Authored-By: Sam Fertig <sam.fertig@codeium.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to Devin run: https://app.devin.ai/sessions/92c5d37729374c61908e0e9746893f36
Requested by: @samfert-codeium
This PR implements comprehensive accessibility improvements to make Firefly III fully compliant with WCAG 2.1 AA standards, addressing keyboard navigation, screen reader compatibility, visual accessibility, content structure, and accessible forms.
Changes in this pull request:
Core Accessibility Infrastructure
banner,navigation,main,contentinfo,complementary) to main layout.sr-onlyutility class for screen reader-only contentForm Accessibility Enhancements
aria-describedby,aria-invalid, andaria-requiredto all form inputsrole="alert"and proper ID referencesaria-describedbyattributesNavigation & Interactive Elements
aria-expandedattributes to collapsible menu itemsaria-labelledby,aria-describedby, andaria-hiddenattributesContent Structure
scopeattributes to table headers and ARIA labels to complex tablesaria-hiddenfor decorative iconsJavaScript Enhancements
accessibility.jswith:Visual & Responsive Design
prefers-reduced-motionmedia query supportdir="ltr"to HTML elementAreas Requiring Careful Review
options.helpTextvshelpText)Testing Recommendations
Manual Accessibility Testing:
Visual Testing:
Cross-browser Testing:
This represents a significant accessibility improvement that should make Firefly III usable by users with disabilities while maintaining full functionality for all users.