Improve accessibility for WCAG 2.1 AA compliance#2
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
Improve accessibility for WCAG 2.1 AA compliance#2devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
- Add semantic HTML structure with proper landmarks (main, nav, header, footer) - Implement comprehensive ARIA labels and descriptions throughout the application - Add skip links for keyboard navigation to main content - Enhance Vue.js components with proper form accessibility patterns - Add live regions for dynamic content announcements (flash messages, errors) - Improve heading hierarchy and focus management - Add screen reader support for interactive elements - Include multilingual accessibility labels in translation system Changes cover both v1 (Twig/Vue.js) and v2 (Blade/Alpine.js) interfaces: - Layout templates: semantic structure, navigation labels, breadcrumb accessibility - Vue components: combobox patterns, form labeling, error announcements - Flash messages: proper alert roles and live regions - Translation keys: comprehensive accessibility labels in English These improvements enhance usability for users with disabilities while maintaining existing functionality and design patterns. Co-Authored-By: Sam Fertig <sam.fertig@codeium.com>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to Devin run: https://app.devin.ai/sessions/56b4722a407a491099f0163e0f294ddc
Requested by: @samfert-codeium
Summary
This PR implements comprehensive accessibility improvements to make Firefly III compliant with WCAG 2.1 AA standards. The changes enhance usability for users with disabilities while maintaining existing functionality and design patterns.
Changes in this pull request:
<main>,<nav>,<header>,<footer>) with ARIA labels across both v1 (Twig) and v2 (Blade) layout templatesFiles Modified:
Layout Templates
resources/views/layout/default.twig- v1 interface accessibility improvementsresources/views/v2/layout/v2.blade.php- v2 interface accessibility improvementsresources/views/partials/flashes.twig- Flash message accessibilityVue.js Components
resources/assets/v1/src/components/transactions/CreateTransaction.vue- Form accessibility and live regionsresources/assets/v1/src/components/transactions/AccountSelect.vue- Combobox patterns and proper labelingresources/assets/v1/src/components/transactions/Amount.vue- Form accessibility and error handlingresources/assets/v1/src/components/transactions/TransactionDescription.vue- Combobox accessibilityTranslations
resources/lang/en_US/firefly.php- Added accessibility-related translation keysThis PR requires careful testing as the accessibility improvements could not be fully validated due to local environment setup issues.
Critical Review Checklist:
Potential Risk Areas:
The accessibility improvements follow established WCAG 2.1 AA guidelines and leverage existing application patterns like the
sr-onlyclass and translation system for consistency.