feat: Implement WCAG 2.2 accessibility compliance improvements#4
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
feat: Implement WCAG 2.2 accessibility compliance improvements#4devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
- Fix skip links CSS to be visible on focus instead of hidden - Add semantic HTML landmarks (main, nav, aside) with ARIA labels - Fix hardcoded lang attributes to use dynamic locale in 6 templates - Add skip links to main layout templates for keyboard navigation - Improve page titles with dynamic context and descriptions - Add role attributes and ARIA labels to navigation elements - Enhance sidebar and footer accessibility with proper landmarks This addresses WCAG 2.2 principles: Perceptible, Operable, Understandable, and Robust for better screen reader and keyboard navigation support. Co-Authored-By: Sam Fertig <sam.fertig@codeium.com>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WCAG 2.2 Accessibility Compliance Implementation
Link to Devin run: https://app.devin.ai/sessions/e4813fe95bff409bb77bb33487140aa8
Requested by: Sam Fertig (@samfert-codeium)
This PR implements comprehensive accessibility improvements to bring Firefly III into compliance with WCAG 2.2 standards, addressing the four main principles: Perceptible, Operable, Understandable, and Robust.
Changes in this pull request:
High Priority Fixes (WCAG Level A/AA):
display: nonewith proper positioning that makes skip links visible on keyboard focus<main>,<nav>,<aside>elements with proper ARIA roles and labelslang="en"with dynamic{{ trans('config.html_language') }}in 6 template filesMedium Priority Improvements:
role="menubar"and ARIA labels to sidebar navigation elements<main>elements with proper ARIA labelingFiles Modified:
resources/assets/v2/src/sass/app.scss- Skip links CSS implementationresources/views/layout/default.twig- Main layout accessibility improvementsresources/views/layout/empty.twig- Page title enhancementsCritical Review Points:
skip_to_contentskip_to_navigationmain_navigationmain_content{{ trans('config.html_language') }}resolves properlyWCAG 2.2 Compliance Status:
This implementation focuses on the most critical accessibility barriers while maintaining backward compatibility with existing functionality.