Fix 814 SonarQube code quality issues (Phases 1 and 2.2)

[devin-ai-integration]

This PR addresses 814 SonarQube code quality issues identified in the codebase. The changes are focused on low-risk, mechanical improvements that enhance code maintainability and follow modern best practices.

Link to Devin run: https://app.devin.ai/sessions/8b51707f33b542e7b88979a2716c1a17
Requested by: Sam Fertig (@samfert-codeium)

Changes in this pull request:

Phase 1: Quick Wins (771 issues fixed)

1.1 Removed Commented Out Code (390 lines across 115 files)

• Removed commented debug statements, dead code, and obsolete implementations
• Preserved license headers and documentation comments
• Affected files: Controllers, Repositories, Services, Routes, Vue components

1.2 JavaScript Modernization (178 changes across 39 files)

• Replaced window. with globalThis. for better ES2020 compatibility
• Replaced parseInt() with Number.parseInt() and parseFloat() with Number.parseFloat()
• Modernized JavaScript in Vue components and asset files

1.3 PHP empty() Improvements (72 replacements across 26 files)

• Replaced count($array) === 0 with empty($array)
• Replaced count($array) > 0 with !empty($array)
• More idiomatic PHP code for checking empty arrays

Phase 2: Web Accessibility (43 issues fixed)

2.2a Table Header Accessibility (39 fixes across 4 files)

• Added scope="col" attributes to table headers for better screen reader support
• Files: accounts/index.blade.php, list/groups.twig, debug-table.twig, transactions/show.blade.php

2.2b Removed Commented HTML (4 fixes across 3 files)

• Removed commented HTML/template code from Blade templates
• Files: accounts/index.blade.php, layout/v2.blade.php, tags.blade.php

Testing

✅ PHP Syntax Check: All files pass lint
✅ Unit Tests: 373 tests, 376 assertions, 0 failures
⚠️ Manual Testing: Not performed (UI changes should be visually verified)

Review Checklist

High Priority:

• Verify empty() replacements don't break logic in edge cases (empty() also checks null/false/0, not just array length)
• Confirm removed comments weren't important documentation or license headers
• Test JavaScript changes work in target browsers (globalThis requires ES2020 support)

Medium Priority:

• Visually verify table accessibility changes render correctly
• Spot check a few files to ensure no functional code was accidentally removed

Risk Assessment

Low Risk:

• Commented code removal (mostly dead code)
• Table scope attributes (straightforward accessibility improvement)

Medium Risk:

• JavaScript modernization (browser compatibility consideration)
• empty() replacements (behavioral differences in edge cases)

Additional Context

This PR addresses approximately 39.5% (814 / 2,061) of all SonarQube issues in the repository. The remaining issues include:

• Duplicated string literals (224 issues)
• Complex web accessibility improvements (192 issues)
• Cognitive complexity refactoring (92 issues)
• Method count violations (35 issues)
• TODO comments (212 issues)

These remaining issues require more complex refactoring and are candidates for future PRs.

[devin-ai-integration]

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

• Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
• Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

• Disable automatic comment and CI monitoring