feat: enhance clear history to optionally keep pinned, bookmarked, and tagged items#40
Open
samirpatil2000 wants to merge 1 commit into
Open
feat: enhance clear history to optionally keep pinned, bookmarked, and tagged items#40samirpatil2000 wants to merge 1 commit into
samirpatil2000 wants to merge 1 commit into
Conversation
… and tagged items
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enhances the "Clear History" action to give users the option to preserve pinned, bookmarked, and tagged items instead of wiping everything. Also includes several UX improvements around focus management when entering/exiting edit and tag-input modes.
Changes
🗑️ Selective Clear History
ClipboardStore.clear(keepProtected:)— New optional parameter. Whentrue, only deletes items that are not pinned, bookmarked, or tagged, while keeping protected items intact.StatusBarController— The clear history confirmation dialog now includes a checkbox: "Keep pinned, bookmarked, and tagged items" (on by default). The informative text updates dynamically based on the checkbox state.🧹 Equatable cleanup
ClipboardItem.swift— Removed the custom==operator that compared only byid. The struct now uses default memberwise equality, which is safer for change detection.🎯 Focus Management Improvements
HistoryWindow.swift— Several fixes to ensure proper focus transitions:Testing