Add theme support with 5 built-in themes + Fix settings window crash#9
Open
dupenodi wants to merge 3 commits into
Open
Add theme support with 5 built-in themes + Fix settings window crash#9dupenodi wants to merge 3 commits into
dupenodi wants to merge 3 commits into
Conversation
- Add ThemeManager with System, Midnight, Sage, Sunset, Mono themes - Add theme switcher dots to history window action bar - Add theme picker swatches to Settings view - Persist selected theme to UserDefaults
dupenodi
changed the title
Contributor
Author
|
@samirpatil2000 removed the theme switcher from the history window. it's only in the settings now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NSApp.appearancefor light/dark and cascades accent color through SwiftUI via.accentColor()UserDefaultsIMPORTANT - Bug fix: Settings window crashed with unrecognized selector when reopened after closing —
caused by NSWindow being deallocated on close (isReleasedWhenClosed defaults to true) while
settingsWindow held a dangling reference. Fixed by setting isReleasedWhenClosed = false.