README: state the exact-only calc folding rule - #213
Merged
Conversation
The rule lived only in the exact_div comment, the fold_custom_calc comment and a test name, so the mul-vs-div asymmetry reads as an inconsistency on first contact and has twice been mistaken for a bug.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--minifyfoldscalc()arithmetic only when the fold is exactly value-preserving, but the rule was only visible in theexact_divcomment, thefold_custom_calccomment and a test name. That leaves the multiplication-versus-division asymmetry looking like an inconsistency, which has twice been read as a bug and once acted on.