feat: prevent building public files

[maltoze]

I have a pre-compiled js file under public folder, which is included in the content_scripts of the manifest file. However, writeBuild will overwrite it.

[samrum]

Is this only an issue in dev mode? What happens on build?

[maltoze]

updated

using this in my manifest.😂

process.env.NODE_ENV === 'development' ? 'foo.js' : 'public/foo.js'

maybe we should also ignore public files from here.

vite-plugin-web-extension/src/devBuilder/devBuilder.ts

Line 179 in 600cb8b

protected async writeManifestScriptFile(fileName: string): Promise<string> {

then there is no need to check NODE_ENV and use public/foo.js directly.

[samrum]

Yeah, I think that'll be the more correct solution. All of the write functions shouldn't be writing anything that exists in the public directory. Similarly for the build functions.

[maltoze]

This function will return null when building. It seems that we only need to focus on dev mode.

vite-plugin-web-extension/src/utils/loader.ts

Lines 57 to 66 in 600cb8b

	export function getScriptLoaderForOutputChunk(
	contentScriptFileName: string,
	chunk: OutputChunk
	): { fileName: string; source: string } | null {
	if (!chunk.imports.length && !chunk.dynamicImports.length) {
	return null;
	}
	return getScriptLoaderFile(contentScriptFileName, [chunk.fileName]);
	}

[samrum]

Does this copy need to happen? Wouldn't all public files have already been copied by line 67?

[maltoze]

I believe it is necessary because their behaviors are different.
line 67: public/foo.js -> dist/foo.js
this line: public/foo.js -> dist/public/foo.js

[samrum]

Ah, ok. Line 67 is correct. The contents of public are supposed to be copied to the root of the dist directory not a subdirectory [1] so we wouldn't want this line.

[maltoze]

If we include public/foo.js in the content scripts section of the manifest, it will not be found.