Skip to content

Allow X-Requested-With with value XMLHttpRequest over XmlHttpRequest #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
samsonasik merged 6 commits into from
Jan 8, 2026
Merged

Allow X-Requested-With with value XMLHttpRequest over XmlHttpRequest #109

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ca6b2ec
Use more modern XMLHttpRequest over XmlHttpRequest
samsonasik Jan 8, 2026
3a51ba4
use strcasecmp() as fallback ensure different combination of case
samsonasik Jan 8, 2026
799269e
ensure old XmlHttpRequest keep working
samsonasik Jan 8, 2026
c7e7c84
cs fix
samsonasik Jan 8, 2026
b1dcada
ensure old XmlHttpRequest keep working
samsonasik Jan 8, 2026
12395f2
rectify
samsonasik Jan 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions spec/Middleware/MezzioSpec.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -327,7 +327,7 @@
);

$request = $this->request;
$request = $request->withHeader('X-Requested-With', 'XmlHttpRequest');
$request = $request->withHeader('X-Requested-With', random_int(0, 1) !== 0 ? 'XMLHttpRequest' : 'XmlHttpRequest');

$handler = Double::instance(['implements' => RequestHandlerInterface::class]);
allow($handler)->toReceive('handle')->with($request)->andRun(function (): never {
Expand Down Expand Up @@ -364,7 +364,7 @@
);

$request = $this->request;
$request = $request->withHeader('X-Requested-With', 'XmlHttpRequest');
$request = $request->withHeader('X-Requested-With', random_int(0, 1) !== 0 ? 'XMLHttpRequest' : 'XmlHttpRequest');

$handler = Double::instance(['implements' => RequestHandlerInterface::class]);
allow($handler)->toReceive('handle')->with($request)->andRun(function (): never {
Expand Down Expand Up @@ -401,7 +401,7 @@
);

$request = $this->request;
$request = $request->withHeader('X-Requested-With', 'XmlHttpRequest');
$request = $request->withHeader('X-Requested-With', random_int(0, 1) !== 0 ? 'XMLHttpRequest' : 'XmlHttpRequest');

$handler = Double::instance(['implements' => RequestHandlerInterface::class]);
allow($handler)->toReceive('handle')->with($request)->andRun(function (): never {
Expand Down Expand Up @@ -436,7 +436,7 @@
);

$request = $this->request;
$request = $request->withHeader('X-Requested-With', 'XmlHttpRequest');
$request = $request->withHeader('X-Requested-With', random_int(0, 1) !== 0 ? 'XMLHttpRequest' : 'XmlHttpRequest');

$handler = Double::instance(['implements' => RequestHandlerInterface::class]);
allow($handler)->toReceive('handle')->with($request)->andRun(function () use ($exception): never {
Expand Down
3 changes: 2 additions & 1 deletion src/Middleware/Mezzio.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@

use function ErrorHeroModule\detectMessageContentType;
use function ErrorHeroModule\isExcludedException;
use function strcasecmp;

final class Mezzio implements MiddlewareInterface
{
Expand Down Expand Up @@ -101,7 +102,7 @@ private function showDefaultView(): Response|HtmlResponse
/** @var ServerRequestInterface $request */
$request = $this->request;
$isXmlHttpRequest = $request->hasHeader('X-Requested-With')
&& $request->getHeaderLine('X-Requested-With') === 'XmlHttpRequest';
&& strcasecmp($request->getHeaderLine('X-Requested-With'), 'XMLHttpRequest') === 0;

if (
$isXmlHttpRequest &&
Expand Down
Loading