Merged
Conversation
…g file to and from /.config directory in user file system
grivera64
requested changes
Aug 30, 2025
Comment on lines
-10
to
+11
| QString configPath = qgetenv("CONFIG_DIR"); | ||
| if (configPath.isEmpty()) | ||
| QString userSyntaxDir = QDir::homePath() + "/.config/codeastra/syntax"; | ||
| QDir dir(userSyntaxDir); |
Member
There was a problem hiding this comment.
Should we still provide a way to change the default config location?
It could be a good idea to keep a universal location for these files for simplicity (and security) reasons as is done here now.
Member
Author
There was a problem hiding this comment.
I believe this is the universal location. I took the same example as Neo Vim, where the config is located at /.config/nvim/*
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors how we handle syntax-highlighting files. Instead of fetching from the project directory, when users first run the project, a new directory will be created in the user's config directory in the home directory named
/.config/codeastra/syntax/*. All the default syntax highlight configuration will then be migrated there.Users can still update an existing syntax config file or create a new one, but this time directly from
~/.config/codeastra/syntax/xxx.syntax.yamlrather than this project directory.