Predicate based matching on HttpRequestMessage#27
Open
Joshhua5 wants to merge 1 commit intosandermvanvliet:masterfrom
Open
Predicate based matching on HttpRequestMessage#27Joshhua5 wants to merge 1 commit intosandermvanvliet:masterfrom
Joshhua5 wants to merge 1 commit intosandermvanvliet:masterfrom
Conversation
Owner
|
I'm not sure I would want to take this direction with the package because it moves away from the expressiveness I had in mind when I built this. Let me try to explain what I mean by that. Consider someone stumbling on this library (or in existing code via IntelliSense) and seeing the handler
.RespondTo()
.Get()
.AndWhen(req => req.Path == "whatever" &&
reg.Headers.Accept == "text/plain" &&
req.Headers["Cookie"] == "testcookie=1");which is (again, in my opinion) harder to understand than it's equivalent: handler
.RespondTo()
.Get()
.ForUrl("whatever")
.Accepting("text/plain")
.AndCookie("testcookie", "1");While this may seem contrived I want to push people into the pit of success and guide to the intended usage. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Something like this would solve all of our needs for matching, if you approve of the direction, I'll go ahead and add the documentation and additional tests.