Skip to content

Big update with many features, performance and non abandoned dependencies#6

Draft
FauconSpartiate wants to merge 15 commits intosankethsj:mainfrom
FauconSpartiate:merge-myQR
Draft

Big update with many features, performance and non abandoned dependencies#6
FauconSpartiate wants to merge 15 commits intosankethsj:mainfrom
FauconSpartiate:merge-myQR

Conversation

@FauconSpartiate
Copy link

@FauconSpartiate FauconSpartiate commented May 18, 2024

Great app, I have added some features that I liked to see, now I'm preparing all this mess to be merged back. I ended up rewriting way more than I thought. Sorry about that.
Some bugfixing is still needed to merge it back, I am working on it.

Big Rewrites

  • Upgraded project structure
  • Upgraded dependencies
  • Moved away from abandoned dependencies (Improved camera performance on the way)
  • Fixed outdated code

New Features

  • Added auto theme detection
  • Added dynamic color detection
  • Added "System" theme mode alongside dark and light
  • Added splash screen
  • Added "Automatically open links" setting
  • Added "Scan again" button
  • Added UI for disabled scan history
  • Added different actions depending on QR content (Open link, Connect to WiFi network, Send email, Call number, Send SMS, Open in Maps, Add to contacts, Add to calendar)
  • Save all the entire barcode payload to the DB, not only the display value
  • Allow scanning other barcodes than QR (everything supported by the mobile_scanner package)

Improvements

  • Improved theme and general UI
  • Improved theme setting
  • Updated app icons, added monochrome and adaptive icons
  • Updated transitions
  • Keep pages alive when navigating
  • Improved AppBar titles
  • Improved camera overlay
  • Show more info about the scan

Bugfixes

  • Fixed scan history setting
  • Fixed many issues related to the camera and torch
  • Fixed FPS issues
  • Fixed code style (formatted using dart format .)
  • Fixed many other bugs

Other Stuff

  • Added correct support for borderless Android displaying
  • Delete files from unsupported platforms

Remaining issues

  • Material color issues with Flutter 3.22 (Waiting for version 8.0.0 of flex_color_scheme)

Out of scope remaining issues

  • README.md should be updated to reflect that all types of barcodes are supported
  • README.md should be updated with new screenshots

Remaining questions

  • DB has to be upgraded to save the entire barcode payload, not only the display value. Is it acceptable to just drop all previously saved data, or should there be an upgrade path? @sankethsj

@sankethsj
Copy link
Owner

Hi @FauconSpartiate ,
Thank you for your efforts. Unfortunately, I had not seen your PR and made many changes. There might be many conflicts.
Let's me see how we can merge these.
Please consider checking new changes.

sankethsj and others added 5 commits July 3, 2024 18:47
updated Scanner UI

updated link to release

added scan history

updated version
Upgrade and clean up dependencies

Add monochrome and adaptive icon

Update Android and iOS config

Add options and features, add dynamic coloring and other stuff

Upgrade package

Update Android config

Fix monochrome icon size

Bring everything to 21st century

Fix overlay

Upgrade packages

Fix Flutter 3.22 warnings

Revert name changes

Run dart format

Add "System" theme mode and change theme settings tile

Formatting

Remove buggy code

Restore save to gallery functionality

Format

Add better page transitions

Fix typos in README

Hide keyboard when tapping outside textfield

Fix logic issue

Rebase on main, commit pending changes
@sankethsj
Copy link
Owner

Hi @FauconSpartiate , thank you so much for your efforts on this. We can drop the all previous data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants