Kirill Makarikhin#6
Open
kirmakar wants to merge 2 commits intosanmaal:masterfrom
Open
Conversation
sanmaal
reviewed
Aug 22, 2018
| }); | ||
|
|
||
|
|
||
| app.get('/login', function (req, res) { |
Owner
There was a problem hiding this comment.
какие-то роуты у тебя прописаны в константы, а какие-то просто строки, лучше делать как-то одинаково
|
|
||
| const connectionString = `postgres://${user}:${password}@${server}:${port}/${database}`; | ||
|
|
||
| module.exports = connectionString; No newline at end of file |
Owner
There was a problem hiding this comment.
лучше для хранения настроек доступа к базе использовать переменные окружения
| const selectUserByLoginQuery = `SELECT * FROM users WHERE login = '${login}'`.replace(/["]+/g,''); | ||
| const results = []; | ||
| let i = 0; | ||
| await pg.connect(connectionString, (err, client, done) => { |
Owner
There was a problem hiding this comment.
что-то у тебя и await и колбек - это действительно надо прям вот так использовать?
| }); | ||
|
|
||
|
|
||
| app.get('/content', auth, function (req, res) { |
Owner
There was a problem hiding this comment.
а что этот роут делает, если я авторизован?
| @@ -0,0 +1,176 @@ | |||
| const {express,app,ROUTES,path,pg,connectionString,bodyParser,bcrypt, passport, session} = require("./config"); | |||
Owner
There was a problem hiding this comment.
такое общее замечание - у тебя один супер модуль, который делает все, его довольно тяжело читать, стоит разбить на несколько частей
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.