feat: add campfire email notifications for pending endpoint approvals#772
Open
notandy wants to merge 1 commit into
Open
feat: add campfire email notifications for pending endpoint approvals#772notandy wants to merge 1 commit into
notandy wants to merge 1 commit into
Conversation
notandy
requested review from
a team,
m-kratochvil,
notque and
ronchi-oss
as code owners
notandy
force-pushed
the
feature/campfire-email-notifications
branch
from
eecd378 to
5482eda
Compare
Adds a notifier package that sends email notifications via Campfire when endpoints are pending approval. Includes immediate notifications on new pending endpoints and a scheduled digest for stale ones. Uses separate queries in QueryPendingEndpoints to avoid scany duplicate column errors from joined service/endpoint tables.
notandy
force-pushed
the
feature/campfire-email-notifications
branch
from
5482eda to
098acde
Compare
Merging this branch will not change overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a notifier package that sends email notifications via Campfire when endpoints are pending approval. Includes immediate notifications on new pending endpoints and a scheduled digest for stale ones.