Skip to content

volume migration: Pre-check for snapshots #580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
grandchild wants to merge 1 commit into
base: stable/2023.2-m3
Choose a base branch
from
Open

volume migration: Pre-check for snapshots #580

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions nova/virt/vmwareapi/vmops.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,7 @@
from nova.virt.vmwareapi import vif as vmwarevif
from nova.virt.vmwareapi import vim_util
from nova.virt.vmwareapi import vm_util
from nova.volume import cinder


CONF = nova.conf.CONF
Expand Down Expand Up @@ -3149,6 +3150,18 @@ def live_migration(self, context, instance, migrate_data, volume_mapping,
if not target_mapping: # Not a volume
locator.datastore = datastore
else:
if target is not self and volume_mapping:
# We cannot migrate volumes with snapshots across
# vCenters.
if volume_id := target_mapping.get('volume_id'):
snapshots = cinder.cinderclient(context) \
.volume_snapshots.list(
search_opts={'volume_id': volume_id})
if snapshots:
reason = _("Volume %s has snapshots and "
"cannot be migrated across "
"vCenter instances.") % volume_id
raise exception.MigrationError(reason=reason)
locator.datastore = target_mapping["datastore_ref"]
profile_id = target_mapping.get("profile_id")
if profile_id:
Expand Down