fix: Replace bare except with explicit RuntimeError handling (#101)#102
Open
somdipto wants to merge 3 commits into
Open
fix: Replace bare except with explicit RuntimeError handling (#101)#102somdipto wants to merge 3 commits into
somdipto wants to merge 3 commits into
Conversation
Author
|
hey guys can you please review my PR and leme know if there are any issue in that |
…h and detailed Mermaid architecture diagrams
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixed the bare
except:clause in evaluate.py that was catching all exceptions including KeyboardInterrupt and SystemExit.Changes
except:with explicitRuntimeErrorhandlingTesting
Linked Issue
Fixes #101