Add mkhomedir hook#5
Open
matteo-chesi wants to merge 3 commits intomainfrom
Open
Conversation
Madeeks
reviewed
Apr 28, 2026
| "when": { | ||
| "always": true | ||
| }, | ||
| "stages": ["prestart"] |
Member
There was a problem hiding this comment.
I have 2 comments about this:
prestartis deprecated, the stage should be eithercreateRuntimeorcreateContainer- According to the spec,
prestartis equivalent tocreateRuntime. However, I can't understand how this hook can work in that case:createRuntimehooks execute in the runtime namespaces, therefore they should not be able to see the mountpoint with the container rootfs, unless they join the container mount namespace, an action which I can't seem to find in the current code. I'm clearly missing something here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to create user HOME directory if missing on the container.
Keep in mind, there is nothing that will make the user land in HOME.