test(amqp091): join connectionWatcher goroutines in test teardown#109
Merged
Conversation
Add a sync.WaitGroup to BrokerDetails so the connectionWatcher goroutine started by Connect is joinable, and a stopWatcher test helper that disconnects a client and waits for its watcher to exit. Defer it in every Connect-based test so a watcher can no longer outlive its test and either race the package-level NewAmqpConn091 swap (read in connect()) or panic calling IsClosed() on a stale mock from its 30s fallback branch. Signed-off-by: Michael Otteni <MichaelGOtteni@gmail.com>
rsperl
reviewed
Jun 1, 2026
Follow Go convention of passing context.Context as the first parameter. Reorders the stopWatcher signature and updates all call sites. Signed-off-by: Michael Otteni <MichaelGOtteni@gmail.com>
Contributor
|
@miotte - Looks great. Could you move whatever is necessary in the PR description to the ticket instead? To keep the changelog manageable, we'd like for the PR desc to just be a couple of lines max. |
Contributor
Author
|
@rsperl Do the commit message bodies need to be pruned as well? |
miotte
added a commit
that referenced
this pull request
Jun 10, 2026
* test(amqp091): join connectionWatcher goroutines in teardown Add a sync.WaitGroup to BrokerDetails so the connectionWatcher goroutine started by Connect is joinable, and a stopWatcher test helper that disconnects a client and waits for its watcher to exit. Defer it in every Connect-based test so a watcher can no longer outlive its test and either race the package-level NewAmqpConn091 swap (read in connect()) or panic calling IsClosed() on a stale mock from its 30s fallback branch. --------- Signed-off-by: Michael Otteni <MichaelGOtteni@gmail.com>
miotte
added a commit
that referenced
this pull request
Jun 10, 2026
The stopWatcher teardown line added in #109 pushed the near-identical Test_ClientExists/Test_ClientExists_false pair over golangci-lint's dupl threshold. Collapse them into one table-driven test so the shared setup lives in a single place. Signed-off-by: Michael Otteni <MichaelGOtteni@gmail.com>
miotte
added a commit
that referenced
this pull request
Jun 10, 2026
* test(amqp091): join connectionWatcher goroutines in teardown Add a sync.WaitGroup to BrokerDetails so the connectionWatcher goroutine started by Connect is joinable, and a stopWatcher test helper that disconnects a client and waits for its watcher to exit. Defer it in every Connect-based test so a watcher can no longer outlive its test and either race the package-level NewAmqpConn091 swap (read in connect()) or panic calling IsClosed() on a stale mock from its 30s fallback branch. --------- Signed-off-by: Michael Otteni <MichaelGOtteni@gmail.com>
miotte
added a commit
that referenced
this pull request
Jun 10, 2026
The stopWatcher teardown line added in #109 pushed the near-identical Test_ClientExists/Test_ClientExists_false pair over golangci-lint's dupl threshold. Collapse them into one table-driven test so the shared setup lives in a single place. Signed-off-by: Michael Otteni <MichaelGOtteni@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #108
Add a
sync.WaitGrouptoBrokerDetailsso theconnectionWatchergoroutine started byConnectis joinable, plus astopWatchertest helper deferred in everyConnect-based test so a watcher can no longer outlive its test and race theNewAmqpConn091swap or panic on a stale mock.Stacked on #102; retarget to
mainonce it merges.