fix: call DELETE properly on HTTP endssas calls.#675
Merged
DMcGee-SAS merged 3 commits intoJul 8, 2026
Conversation
Signed-off-by: domcge <don.mcgee@sas.com> Signed-off-by: Michael Senter <dmsenter89@gmail.com>
PR sassoftware#663 introduced a new sess_started attribute to the SASconfigHTTP class, while only the sess_started attribute ofthe SASsessionHTTP class was in use. PR sassoftware#664 then accidentally checked `SASconfigHTTP.sess_started` as opposed to `SASsessionHTTP.sess_started`. This commit removes the unused attribute and fixes the flawed comparison. Signed-off-by: Michael Senter <dmsenter89@gmail.com>
Signed-off-by: Michael Senter <dmsenter89@gmail.com>
dmsenter89
force-pushed
the
fix-compute-session-termination
branch
from
July 8, 2026 20:32
8ad582c to
7ac87a4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR address?
On HTTP connections, SASPy can leave dangling compute pods. The root was that for HTTP connections,
SASsession.endsas()didn't call the DELETE endpoint. The bug was introduced by PR #664 which checked theSASconfigHTTP.sess_startedattribute introduced in PR #663 as part of a session re-use feature. This appears to have been a typo and theSASsessionHTTP.sess_startedwas intended.How does it fix it?
The correct attribute is now being queried in the endssas call:
To prevent future misunderstandings, the unused
SASconfigHTTP.sess_startedattribute was removed fromSASconfigHTTP.__init__, since only theSASsessionHTTP.sess_startedis in use.A new test case was added, and my previously contributed test case was merged into the new test file.
Signed-off-by: Michael Senter, PhD dmsenter89@gmail.com