Skip to content

refactor: Transfer MacroDotNet to dedicated repo#94

Merged
sator-imaging merged 1 commit intomainfrom
refactor/extract-MacroDotNet
Mar 15, 2026
Merged

refactor: Transfer MacroDotNet to dedicated repo#94
sator-imaging merged 1 commit intomainfrom
refactor/extract-MacroDotNet

Conversation

@sator-imaging
Copy link
Copy Markdown
Owner

@sator-imaging sator-imaging commented Mar 15, 2026

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request performs a significant refactoring by extracting the MacroDotNet project into its own dedicated repository. The changes involve removing all MacroDotNet-related files, configurations, and documentation from the current codebase, ensuring a cleaner separation of concerns and streamlining the project structure. This move facilitates independent development and maintenance of MacroDotNet while simplifying this repository.

Highlights

  • Project Extraction: The MacroDotNet project, including its source code, tests, and associated build artifacts, has been entirely removed from this repository.
  • Configuration Updates: The .gitignore file, solution file (FGenerator.slnx), and various README.md files have been updated to reflect the removal of MacroDotNet and to point to its new dedicated repository.
  • Test Cleanup: References to MacroDotNet and its test cases have been removed from test/packaged-generators-test.cs.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • .gitignore
    • Removed entries for MacroDotNet and MacroDotNet.Test.
  • Compiled/MacroDotNet.dll.meta
    • Removed the metadata file for MacroDotNet.dll.
  • Compiled/MacroDotNet.nuspec
    • Removed the NuGet package specification file for MacroDotNet.
  • Compiled/README.md
    • Updated the link for MacroDotNet to its new dedicated repository.
  • FGenerator.slnx
    • Removed the project reference to MacroDotNet.Test.csproj.
  • MacroDotNet.Test/MacroDotNet-syntax.cs
    • Removed the MacroDotNet syntax test fixture file.
  • MacroDotNet.Test/MacroDotNet-test.cs
    • Removed the MacroDotNet test file.
  • MacroDotNet.Test/MacroDotNet.Test.csproj
    • Removed the MacroDotNet test project file.
  • MacroDotNet/MacroDotNet.cs
    • Removed the MacroDotNet source code file.
  • MacroDotNet/README.md
    • Removed the MacroDotNet README documentation.
  • README.ja.md
    • Updated the link for MacroDotNet to its new dedicated repository.
  • README.md
    • Updated the link for MacroDotNet to its new dedicated repository.
  • README.zh-CN.md
    • Updated the link for MacroDotNet to its new dedicated repository.
  • test/packaged-generators-test.cs
    • Removed the package reference and using directive for MacroDotNet.
    • Removed the MacroDotNet test case.
    • Removed the MacroExample partial class and its associated macro definition.
Ignored Files
  • Ignored by pattern: .github/workflows/** (3)
    • .github/workflows/code-scanning.yml
    • .github/workflows/compile_and_PR.yml
    • .github/workflows/test.yml
Activity
  • No human activity has been recorded on this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the repository by transferring the MacroDotNet project to its own dedicated repository. The changes consist of removing all files, tests, project references, and configurations related to MacroDotNet, and updating links in README files to point to the new repository. The changes are consistent and correctly implement the goal of this refactoring. I have not identified any issues or areas for improvement.

@github-actions
Copy link
Copy Markdown
Contributor

Qodana Community for .NET

268 new problems were found

Inspection name Severity Problems
Inconsistent Naming 🔶 Warning 48
Unused type parameter 🔶 Warning 13
Type is never used: Private accessibility 🔶 Warning 10
Unknown issue 🔶 Warning 8
RoslynAnalyzers Missing File Header Comment 🔶 Warning 7
Non-accessed positional property: Non-private accessibility 🔶 Warning 6
Redundant 'partial' modifier on type declaration 🔶 Warning 6
Local variable hides member 🔶 Warning 4
Return type of a function can be made non-nullable 🔶 Warning 3
Namespace does not correspond to file location 🔶 Warning 2
Event never invoked 🔶 Warning 2
Usage of <inheritdoc /> is invalid 🔶 Warning 2
Invalid XML documentation comment 🔶 Warning 2
Non-accessed field: Private accessibility 🔶 Warning 2
Redundant argument with default value 🔶 Warning 2
Auto-property accessor is never used: Non-private accessibility 🔶 Warning 2
Method return value is never used: Private accessibility 🔶 Warning 2
Non-nullable member is uninitialized. 🔶 Warning 1
Use null check pattern instead of a type check succeeding on any not-null value 🔶 Warning 1
Non-accessed local variable 🔶 Warning 1
Redundant nullable annotation on 'class?' constraint of type parameter constrained by non-nullable base type 🔶 Warning 1
RoslynAnalyzers Enum Obfuscation 🔶 Warning 1
Get-only auto-property is never assigned 🔶 Warning 1
Do not use object initializer for 'using' variable: Do not use object initializer for 'using' variable 🔶 Warning 1
Redundant type declaration body ◽️ Notice 32
Type member is never used: Non-private accessibility ◽️ Notice 32
Type is never used: Non-private accessibility ◽️ Notice 32
Member can be made private: Non-private accessibility ◽️ Notice 11
Merge null/pattern checks into complex pattern ◽️ Notice 10
Unused parameter: Non-private accessibility ◽️ Notice 8
Class is never instantiated: Non-private accessibility ◽️ Notice 2
Event is never subscribed to: Non-private accessibility ◽️ Notice 2
For-loop can be converted into foreach-loop ◽️ Notice 2
Conditional expression can be rewritten as null-coalescing ◽️ Notice 2
Use preferred body style: Convert into property, indexer, or event with preferred body style ◽️ Notice 1
Async method without 'await' operators: Async Task method without 'await' operators ◽️ Notice 1
'if' statement can be rewritten as '?:' expression ◽️ Notice 1
Convert into lambda expression ◽️ Notice 1
Non-accessed field: Non-private accessibility ◽️ Notice 1
Redundant [AttributeUsage] attribute property assignment ◽️ Notice 1
Redundant string interpolation ◽️ Notice 1
View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

To get *.log files or any other Qodana artifacts, run the action with upload-result option set to true,
so that the action will upload the files as the job artifacts:

      - name: 'Qodana Scan'
        uses: JetBrains/qodana-action@v2025.3.1
        with:
          upload-result: true
Contact Qodana team

Contact us at qodana-support@jetbrains.com

@sator-imaging sator-imaging merged commit 8053908 into main Mar 15, 2026
12 checks passed
@sator-imaging sator-imaging deleted the refactor/extract-MacroDotNet branch March 15, 2026 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant