Prefer array over list

[sator-imaging]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors several parts of the codebase to optimize collection usage by preferring arrays over lists. By converting dynamic lists to fixed-size arrays or removing redundant list creations, the changes aim to improve memory allocation efficiency and potentially enhance performance in various data processing flows within the application.

Highlights

• Collection Optimization: Replaced instances of .ToList() with .ToArray() across multiple files to prefer fixed-size arrays where appropriate, potentially improving performance and memory usage.
• Reduced Intermediate Collections: Eliminated an unnecessary .ToList() call in the FUnitSourceGenerator to avoid creating an intermediate collection when direct enumeration is sufficient.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• cli/Program.cs
  • Converted the collection of C# file paths from a List<string> to a string[].
• directives/FUnitSourceGenerator.cs
  • Removed an unnecessary .ToList() call when enumerating SyntaxKind.WarningDirectiveTrivia.
• src/FUnit.TestSuite.cs
  • Updated the TestsBySubject property to return an IReadOnlyList<string> backed by an array instead of a list.
  • Changed the collection of test errors within the ExecuteCoreAsync method from a List to an Array.
• src/FUnit.cs
  • Converted the collections of failedTestCases and skippedTestCases from List to Array.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request aims to improve performance and memory usage by preferring arrays over lists, which is a good practice for collections that are not modified after creation. Most changes correctly replace .ToList() with .ToArray() or remove unnecessary materialization. However, one of the changes in src/FUnit.TestSuite.cs introduces a compilation error due to a type mismatch. I've left a comment with a suggestion to fix it.