fix(bundle): post-merge cleanup follow-ups from #87 (upstream v0.13.0)#89
Merged
Merged
Conversation
Post-merge cleanup from PR #87 (upstream v0.13.0 sync). Two minor non-blocking items noted in review (#88): 1. src/specify_cli/commands/bundle/__init__.py:829 - use the `hostname` local captured in the try block instead of re-accessing `parsed.hostname` in the final guard, mirroring the sibling fix in src/specify_cli/presets/__init__.py:2093. Behavior unchanged (ParseResult is immutable for a given URL); this is a consistency cleanup to prevent drift in future refactors. 2. docs/reference/extensions.md - add blank lines after the closing code fence (line 180) and after the hook-fields table (line 227) in the new "Project Extension and Hook Configuration" section to satisfy CommonMark block separation. Tests: 651 passed in tests/unit/test_bundle_download_url.py + tests/test_workflows.py (acceptance criterion from #88). Closes #88 Assisted-by: opencode z-ai/glm-5.2 (autonomous)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Post-merge cleanup items from PR #87 review (issue #88). Two minor, non-blocking items, one commit.
Changes
1.
src/specify_cli/commands/bundle/__init__.py:829- reusehostnamelocalAfter the
ValueErrorguard added in upstream v0.13.0, the final host-check re-accessedparsed.hostnameinstead of reusing thehostnamelocal captured in the try block. The sibling fix insrc/specify_cli/presets/__init__.py:2093already uses the local consistently.Behavior unchanged (
ParseResultis immutable for a given URL, so a successful first access won't raise on re-access). This is a consistency cleanup to prevent drift in future refactors.2.
docs/reference/extensions.md- blank lines for CommonMark block separationAdded blank lines after the closing code fence (line 180) and after the hook-fields table (line 227) in the new "Project Extension and Hook Configuration" section introduced by upstream v0.13.0.
Verification
Acceptance criteria from #88:
src/specify_cli/commands/bundle/__init__.py:829useshostnamelocaldocs/reference/extensions.mdhas blank lines after the closing fence (line 180) and after the hook-fields table (line 227).venv/bin/python -m pytest tests/unit/test_bundle_download_url.py tests/test_workflows.py -q-> 651 passed, 1 skipped (pre-existing skip).venv/bin/python -m pytest tests/ --ignore=tests/test_workflows.py -q-> 3783 passed, 113 skipped (pre-existing skips)ruff check src/specify_cli/commands/bundle/__init__.py-> All checks passedpre-prprivacy check -> cleanNote: the repo's
scripts/daily-routine.sh pre-prreports a failure on thecheck-upstream-sync.shstep, but that failure is pre-existing onmain-speckitself - PR #87 was a squash merge (not a direct tag merge), sov0.13.0's commit SHA is not an ancestor ofmain-speck. Unrelated to this fix; tracked separately.Disclosure
Authored and pushed by an AI agent (opencode z-ai/glm-5.2, autonomous) on behalf of @mw. The commit carries the
Assisted-by:trailer per the repo's agent disclosure policy.Closes #88