This repository was archived by the owner on Oct 21, 2020. It is now read-only.
Open
Conversation
Contributor
|
Hey @joshgrantsauce I'm close to finishing this branch here: https://github.com/saucelabs/sauce-java/blob/js2/common/src/test/java/com.saucelabs.common/SauceHelperAcceptanceTest.java And it pretty much overwrites all that you did in this PR. How do you want me to handle it. Our naming conventions are a little different, but I think we had the same idea. Do you want me to merge our branches and rename something? Or should I just PR my branch and we close this one? |
Contributor
|
@nikolay-advolodkin you're farther along than I am, which is great! I'd say merge your changes and I'll either decline or update this PR as needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small updates for removing connections to Sauce Labs in existing unit tests for SOL-13. Also added some possible structure for acceptance tests that do in fact connect to Sauce Labs.