feat: hs skill install — bundle the hearthstone-deck skill with the CLI#14
Merged
Conversation
c2eef8e to
b826800
Compare
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…graceful unknown-agent
b826800 to
6b78f41
Compare
ff3676f to
36cf360
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a channel-agnostic way to install the
hearthstone-deckClaude Code skill alongside thehsCLI, plus publishes/advertises it cross-agent. Implements the D + C + B design (spec + plan committed underdocs/superpowers/).D —
hs skill installsubcommandclaude,cursor,codex,copilot,opencode(matches thenpx skillsdirectory convention).--global(default) or--project.SKILL.md+ recipes) are embedded into the binary via Bun text imports — no network, no Node/npx needed (preserves the brew/binary "no runtime" benefit). Single source of truth stays atplugins/hs-cli/skills/hearthstone-deck/; a test asserts byte-equality between bundle and disk.@clack/promptsmultiselect (rendered to stderr so-f jsonstdout stays pipeable) or non-interactive--agent claude,cursor. Non-TTY without--agent→ guard error + exit 1 (safe for agents that pipe the CLI).--use-npx: short-circuits tonpx skills add say8425/hs-cliwhen npx is available..agents/skills) are de-duplicated — one install + one outcome per physical dir.C — skills.sh publishing
npx skills add say8425/hs-clidiscovershearthstone-deckvia the existing.claude-plugin/marketplace.jsonlayout. Zero restructure needed.B — advertise (no new files)
caveatsblock (inrelease.ymlformula render); install instructions added to all READMEs (en/ko/ja/zh/es + plugin README). No new README (would duplicate SKILL.md).Architecture
Four focused pure services + a thin citty command:
agent-dirs.ts— agent→directory map + path resolverskill-bundle.ts— embedded skill filesskill-installer.ts— pure fs writer (writeBundle,skillExists)skill-select.ts— pure selection resolver (validation + non-TTY guard)commands/skill.ts— clack/npx I/O glue; output viaformatSkillOutcomesinformatter.tsTest Plan
bun run check— lint (0 errors), fmt:check, tsc, 58 tests pass--force; node-target build (dist/index.js) carries embedded skill files (EMBED OK)--agent claude,cursor,codex --project→ 2 outcomes, not 3npx skills add say8425/hs-cli --listdiscovershearthstone-deckhs skill install(compiled-binary execution not runnable locally on macOS codesign; validated on node target + bundler embed)🤖 Generated with Claude Code