Feature/connectedto#14
Open
sbabcock23 wants to merge 3 commits into
Open
Conversation
Contributor
|
Any estimate on when this will be merged into and updated in HACS? |
r-teller
reviewed
Jun 8, 2022
| connectedToString = "Cellular! Signal Strength - " + str(connectedToJSON['signalStrengthPercent']) | ||
| elif typename == 'ConnectedToBase': | ||
| connectedToString = "Base ID - " + connectedToJSON['chargingBase']['id'] | ||
| else: |
Contributor
There was a problem hiding this comment.
There is an additional connection state that can be returned
"lastConnectionState": {
"__typename": "ConnectedToWifi",
"date": "2022-06-08T06:10:57.475Z"
}
Owner
Author
|
Hi @r-teller , Can you take a look at the fiDevice class? This has the connected to details but doesn't quite have the friendly translation as what you proposed in the fiPet class. Since this data is already present there, my suggestion is to enhance the existing class. |
Contributor
|
I think i see what you are referencing, that you had this open PR and since I hoping to key off connectionState in HA |
Owner
Author
|
The changes need to occur in the hass-tryfi repository. a new sensor is probably required that shows the connection state of the collar. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.