Fix: Remove deprecated homeCityState field from BasePet fragment#41
Open
sagig76 wants to merge 1 commit into
Open
Fix: Remove deprecated homeCityState field from BasePet fragment#41sagig76 wants to merge 1 commit into
sagig76 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TryFi recently removed the
homeCityStatefield from theBasePettype in their GraphQL schema. This caused all client queries requesting the field to fail with a400 Bad Requestand crash the Home Assistant TryFi integration.This PR removes the field from
FRAGEMENT_BASE_PET_PROFILEinconst.py. Since the library'sfiPet.pyalready handles the parsing ofhomeCityStatewithin a try-except block (defaulting to 'FakeCity' if missing), this change is fully backward-compatible and resolves the integration setup failure.