refactor(google-auth): introduce helper for iOS client ID URL scheme conversion#17
refactor(google-auth): introduce helper for iOS client ID URL scheme conversion#17sbaiahmed1 merged 1 commit intomainfrom
Conversation
…conversion - Added `getUrlSchemeFromClientId` to simplify and standardize URL scheme creation. - Updated iOS configuration logic to use the new helper function. - Included a new `lint:fix` script in package.json for automated linting fixes.
📝 WalkthroughWalkthroughThis pull request adds an ESLint auto-fix script to package.json and introduces a new helper function in the auth plugin to properly derive iOS URL schemes from Google client IDs by reversing dotted segments, replacing a simpler split-based heuristic. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
📜 Recent review detailsConfiguration used: defaults Review profile: CHILL Plan: Pro 📒 Files selected for processing (2)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
🔇 Additional comments (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
resolves: #13
getUrlSchemeFromClientIdto simplify and standardize URL scheme creation.lint:fixscript in package.json for automated linting fixes.Summary by CodeRabbit
Chores
Bug Fixes
✏️ Tip: You can customize this high-level summary in your review settings.