feat(google-auth): add credentialManagerMode for customizable sign-in behaviour#18
feat(google-auth): add credentialManagerMode for customizable sign-in behaviour#18sbaiahmed1 merged 1 commit intomainfrom
Conversation
… behavior - Introduced `credentialManagerMode` to control sign-in on Android - Updated Android implementation to handle the new parameter with validation - Documented the `credentialManagerMode` option in the TypeScript interface
📝 WalkthroughWalkthroughIntroduces a new Changes
Sequence Diagram(s)sequenceDiagram
participant Client
participant Module as GoogleAuthModule
participant CredMgr as Credential Manager
participant IdP as Google IdP
Client->>Module: configure(credentialManagerMode)
Module->>Module: validate mode
rect rgb(200, 220, 255)
Note over Client,IdP: Silent Mode
Client->>Module: signIn()
Module->>CredMgr: GetGoogleIdOption (silent)
CredMgr-->>Module: error (no credential)
Module-->>Client: SIGN_IN_ERROR
end
rect rgb(220, 200, 255)
Note over Client,IdP: Interactive Mode
Client->>Module: signIn()
Module->>CredMgr: GetSignInWithGoogleOption
CredMgr->>IdP: show account picker
IdP-->>CredMgr: credential
CredMgr-->>Module: credential
Module-->>Client: success
end
rect rgb(200, 255, 220)
Note over Client,IdP: Auto Mode (Default)
Client->>Module: signIn()
Module->>CredMgr: GetGoogleIdOption (silent)
alt credential found
CredMgr-->>Module: credential
Module-->>Client: success
else credential not found
Module->>CredMgr: GetSignInWithGoogleOption
CredMgr->>IdP: show account picker
IdP-->>CredMgr: credential
CredMgr-->>Module: credential
Module-->>Client: success
end
end
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
📜 Recent review detailsConfiguration used: defaults Review profile: CHILL Plan: Pro ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
🔇 Additional comments (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
resolves: #16
credentialManagerModeto control sign-in on AndroidcredentialManagerModeoption in the TypeScript interfaceSummary by CodeRabbit
credentialManagerModeconfiguration option to control Android sign-in flow behavior.✏️ Tip: You can customize this high-level summary in your review settings.