feat(rs): add balance indices (sackin, leaf depth variance, b2)#187
Merged
Neclow merged 6 commits intosbhattlab:mainfrom Feb 6, 2026
Merged
feat(rs): add balance indices (sackin, leaf depth variance, b2)#187Neclow merged 6 commits intosbhattlab:mainfrom
Neclow merged 6 commits intosbhattlab:mainfrom
Conversation
Add new balance module with tree balance/imbalance indices: - Sackin index (sum of leaf depths) - Leaf depth variance - B2 index (Shao & Sokal 1990) Includes comprehensive tests with ladder and balanced tree cases.
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new vector::balance module providing common rooted-binary tree balance/imbalance indices computed from Phylo2Vec vectors.
Changes:
- Introduces
sackin,leaf_depth_variance, andb2metrics underphylo2vec::vector::balance. - Adds rstest-based test coverage for ladder vs balanced tree extremal/known values.
- Updates the codespell whitelist for the term “sackin”.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
phylo2vec/src/vector/mod.rs |
Exposes the new balance module from vector. |
phylo2vec/src/vector/balance.rs |
Implements balance indices and adds unit tests. |
.codespell-whitelist |
Whitelists “sackin” to avoid codespell false positives. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…o2vec into feat/balance-indices
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add new balance module with tree balance/imbalance indices:
Includes comprehensive tests with ladder and balanced tree cases.