Skip to content

Fixup publishes and use implicit capstone dependency #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sc2ad merged 2 commits into from
Sep 1, 2025
Merged

Fixup publishes and use implicit capstone dependency #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d8a6b42
Fixup publish CI
sc2ad Sep 1, 2025
4cdde79
Remove implicit capstone dependency
sc2ad Sep 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions .github/workflows/build-ndk.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ jobs:

# Get QPM so we can bring in dependencies
- name: Setup qpm
if: ${{ !startsWith(github.ref, 'refs/tags/v') }}
uses: Fernthedev/qpm-action@v1
with:
workflow_token: ${{ secrets.GITHUB_TOKEN }}
Expand Down Expand Up @@ -130,6 +129,9 @@ jobs:
files=( $pattern )
echo "NAME=${files[0]}" >> ${GITHUB_OUTPUT}

- name: Rename debug artifact
run: mv "./build/debug/${{ steps.libname.outputs.NAME }}" "./build/debug_${{steps.libname.outputs.NAME }}"

- name: Upload non-debug artifact
uses: actions/upload-artifact@v4
with:
Expand All @@ -141,7 +143,7 @@ jobs:
uses: actions/upload-artifact@v4
with:
name: debug_${{ steps.libname.outputs.NAME }}
path: ./build/debug/${{ steps.libname.outputs.NAME }}
path: ./build/debug_${{ steps.libname.outputs.NAME }}
if-no-files-found: error

- name: Upload qmod artifact
Expand Down
7 changes: 6 additions & 1 deletion shared/fixups.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,15 @@
#pragma once

#include <capstone/capstone.h>
#include <cstddef>
#include <cstdint>
#include <vector>
#include "page-allocator.hpp"
#include "util.hpp"

#if __has_include(<capstone/capstone.h>)
#include <capstone/capstone.h>
#endif

namespace flamingo {

template <class T>
Expand Down Expand Up @@ -82,7 +85,9 @@ struct Fixups {
void Uninstall();
};

#if __has_include(<capstone/capstone.h>)
// TODO: DO NOT EXPOSE THIS SYMBOL (USE IT FOR TESTING ONLY)
csh getHandle();
#endif

} // namespace flamingo
Loading