Bring bindgen up-to-date and add some fixes#200
Open
m8nmueller wants to merge 6 commits intoscala-native:masterfrom
Open
Bring bindgen up-to-date and add some fixes#200m8nmueller wants to merge 6 commits intoscala-native:masterfrom
m8nmueller wants to merge 6 commits intoscala-native:masterfrom
Conversation
Author
|
Segfault appeared: With debug symbols: |
WojciechMazur
approved these changes
Dec 15, 2023
WojciechMazur
left a comment
There was a problem hiding this comment.
Looks good, thank you for making it up to date with latest Scala Native.
|
I believe the changes should be also applied to tests, it's not catched becouse CI is broken and would require moving it from Travis to GHA. I would not be able to allocate a time for that soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bindgen/ir/Record.cpp(for unknown reasons, I have to admit)