Skip to content
This repository was archived by the owner on Jul 14, 2021. It is now read-only.

Add ability to switch/handoff conversation between two Rasa endpoints#150

Open
rgstephens wants to merge 7 commits into
scalableminds:masterfrom
RasaHQ:master
Open

Add ability to switch/handoff conversation between two Rasa endpoints#150
rgstephens wants to merge 7 commits into
scalableminds:masterfrom
RasaHQ:master

Conversation

@rgstephens

Copy link
Copy Markdown

There is an implementation and description of this feature in the Rasa helpdesk example bot docs here.

@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@hotzenklotz

hotzenklotz commented Dec 30, 2020

Copy link
Copy Markdown
Member

What is the purpose of this PR? Looks like you just copied the Rasa fork? Why not use that directly?

@rgstephens

Copy link
Copy Markdown
Author

I'd like to extend this code and think it is a valuable addition to the original project.

@hotzenklotz hotzenklotz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR is a bit tacky as is. Please clean up any changes that were introduced by the Rasa fork that should not affect the current behavior.

Also, I would appreciate it if the Readme was clearer on what this features does. It is a handoff from one Rasa bot backend to another Rasa bot backend. (and not to any other third party service)

You will also need to sign our community contributor license agreement. (see bot message above)

Comment thread README.md
@@ -1,3 +1,8 @@
> This fork is under development to enable handing off from one bot to another.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove

Comment thread README.md

## Usage
1. Embed the `chatroom.js` in the HTML of your website and configure it to connect to your Rasa bot. Either use the S3 hosted version or build it yourself. (see below)
1. Embed the `chatroom.js` in the HTML of your website and configure it to connect to your Rasa bot. Either use the S3 hosted version or build it yourself. (see below) You will have to build it yourself to use the handoff capability

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove line.

Comment thread README.md
```html
<head>
<link rel="stylesheet" href="https://npm-scalableminds.s3.eu-central-1.amazonaws.com/@scalableminds/chatroom@master/dist/Chatroom.css" />
<link rel="stylesheet" href="http://127.0.0.1:8080/dist/Chatroom.css" />

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Undo.

Comment thread README.md
<div class="chat-container"></div>

<script src="https://npm-scalableminds.s3.eu-central-1.amazonaws.com/@scalableminds/chatroom@master/dist/Chatroom.js"/></script>
<script src="http://127.0.0.1:8080/dist/Chatroom.js"/></script>

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Undo

Comment thread debug.html
speechRecognition: "en-US",
welcomeMessage: "Hallo! How can I help you?",
host: "http://localhost:5005"
// speechRecognition: "en-US",

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Undo, speechRecognition comment

Comment thread index.html
voiceLang: "en-US"
welcomeMessage: "Hallo! How can I help you?",
host: "http://localhost:5005"
// speechRecognition: "en-US",

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Undo, speechRec

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants