Add support for countIndexFrom param to avoid count always from index 1#53
Open
jalamprea wants to merge 4 commits intoscaleflex:masterfrom
Open
Add support for countIndexFrom param to avoid count always from index 1#53jalamprea wants to merge 4 commits intoscaleflex:masterfrom
jalamprea wants to merge 4 commits intoscaleflex:masterfrom
Conversation
|
Can we add this? Would really help to be able to move the index around. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current behavior is always to add 1 to the index when the images are loading, but if my images were generated from 0, it will lose one image.
This PR is to add a new parameter to allow set the count-from on the client-side, so by default, it will add 1, but I can pass zero or any other integer value to add to the index.