Accept single URLs (hostname only) as valid#69
Open
ilpianista wants to merge 1 commit intoscharel:masterfrom
Open
Accept single URLs (hostname only) as valid#69ilpianista wants to merge 1 commit intoscharel:masterfrom
ilpianista wants to merge 1 commit intoscharel:masterfrom
Conversation
Author
|
@scharel Up. Any chance you merge this? Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I cannot login because I'm using a single URL (https://foo) which fails to pass the regular expression. This kind of URLs can be used in combination with Tailscale's magic DNS feature or with any local DNS server.
I suppose that nowadays checking for any URL that starts with
http://orhttps://should be enough.