Skip to content

🎨 Palette: Add ARIA error association for add-domain wizard#232

Open
schmug wants to merge 1 commit intomainfrom
palette-add-wizard-aria-error-17587397148569083739
Open

🎨 Palette: Add ARIA error association for add-domain wizard#232
schmug wants to merge 1 commit intomainfrom
palette-add-wizard-aria-error-17587397148569083739

Conversation

@schmug
Copy link
Copy Markdown
Owner

@schmug schmug commented May 2, 2026

💡 What: Added aria-describedby to the domain input field in the Add Domain wizard (src/views/dashboard.ts), and added a matching id, role="alert", and aria-live="polite" to the dynamic error message container (.add-wizard-error).

🎯 Why: Previously, when a user entered an invalid domain in the wizard (e.g., clicking "Next" with an empty or malformed domain), a dynamic error message would appear below the input. However, screen readers would not automatically announce this error, leaving visually impaired users unaware of why they couldn't proceed.

♿ Accessibility:

  • Linked the error container directly to the input field using aria-describedby="wizard-domain-error".
  • Added role="alert" and aria-live="polite" to the error container to ensure screen readers announce the validation failure immediately when it becomes visible without interrupting the user's current focus context.

📸 Before/After: No visual changes, structural HTML changes only.


PR created automatically by Jules for task 17587397148569083739 started by @schmug

Adds `aria-describedby` to the domain input in the add-wizard, and corresponding `id`, `role="alert"`, and `aria-live="polite"` attributes to the error container. This ensures that when dynamic validation errors occur, they are announced correctly by screen readers.

Co-authored-by: schmug <38227427+schmug@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented May 2, 2026

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs
dmarcheck 0e6d5d5 May 02 2026, 01:34 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant