Skip to content

make urifind input/output streamable#2

Open
mauke wants to merge 2 commits into
schwern:masterfrom
mauke:master
Open

make urifind input/output streamable#2
mauke wants to merge 2 commits into
schwern:masterfrom
mauke:master

Conversation

@mauke

@mauke mauke commented Aug 26, 2013

Copy link
Copy Markdown

No description provided.

mauke added 2 commits August 26, 2013 21:22
This makes it suitable for 'tail -f log | urifind', etc.
@schwern

schwern commented Jul 7, 2014

Copy link
Copy Markdown
Owner

This is a good idea, but the sort options can't go away.

@mauke

mauke commented Feb 12, 2015

Copy link
Copy Markdown
Author

Why was it necessary to remove the sort and reverse options?

Because those options require having all URIs in one array that can be sorted at the end. The streaming patch makes urifind print found URIs immediately, without accumulating them. I thought the sort options weren't essential because you can restore the old behavior using urifind | sort or urifind | sort -r, so I simply removed them instead of writing more complicated code that may or may not use @uris depending on the command line options used.

@schwern

schwern commented Feb 24, 2015

Copy link
Copy Markdown
Owner

Ok, you've convinced me the features are redundant with sort and streaming is more important. As a sop to backwards compatibility, would you add error messages if -s or -r are used? Something like...

-s has been removed, consider "urifind | sort" instead.
-r has been removed, consider "urifind | sort -r" instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants