Prevent regex intensive execution which may cause DoS#21
Open
giosh94mhz wants to merge 1 commit into
Open
Conversation
There are many dot-asterisk greedy matches which may cause very intensive, even indefinite, execution of the script. The worst one was the schemeRe match, which if executed (by accident, or by honoring the MIME headers) against a base64 text will cause infinite execution. This patch tested against a ~1MB file, will drop execution wall-clock time from many hundred of seconds, to a couple of seconds.
7beb6a4 to
891ecec
Compare
Author
|
The limit on the scheme to 16 chars, has been set checking against the list in issue #4 , and 16 looks ok to me. Increasing this number to let's say 32, will slow down my samples from ~1 seconds to ~5 seconds, but still better then keeping an open match. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are many dot-asterisk greedy matches which may cause
very intensive, even indefinite, execution of the script.
The worst one was the
schemeRematch, which if executed(by accident, or by honoring the MIME headers) against a
base64 text will cause infinite execution.
This patch tested against a ~1MB file, will drop execution
wall-clock time from many hundred of seconds, to a couple of seconds.