ENH: Bump to 24.04 and tomllib#30
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #30 +/- ##
=======================================
Coverage 94.39% 94.39%
=======================================
Files 2 2
Lines 107 107
=======================================
Hits 101 101
Misses 6 6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Thanks! It was a long time ago when toml people refactored an internal function that we used here, broke something, and Stuart Mumford made decision to copy the old function out because it was the fastest way to fix the incompatibility. Perhaps things are different now. |
There was a problem hiding this comment.
The dependency list here seems unrelated. Is this for testing?
|
Ooof I'm messing with the wrong repo... need to do this to |
There was a problem hiding this comment.
The fix using Auth here is uncontroversial. So if you want to just open a mini PR with this Auth fix, we can probably merge it right away.
Over in MNE-Python we get:
https://github.com/mne-tools/mne-python/actions/runs/18803456223/job/53654097297?pr=13460
So let's bump to
tomllibinstead of usingtoml, which is easily achieved (hopefully) by using 24.04 + Python 3.12 instead of Python 3.10.I don't see anything that actually tries to run the PR'ed version of the action, so I'm going to add a CI workflow to do this first. I'll also add a dummy run first, replicating the issue (hopefully). Then once that works, I'll push a fix.