ENH,MAINT: Rename "relevant" to "dispatch" args and expose in context#13
Merged
Merged
Conversation
This is useful for generic wrappers. I still wan to hold back to do all the work for them, but the information is rather readily available, so I think we can pass it on. NumPy uses "relevant args" naming for the arguments we dispatch on, I decided to rename it to "dispatch" instead. (Also changed to pass a tuple of types, because I think that is more future proof. We expect few types, a set isn't useful e.g. if done in C.)
Contributor
Author
|
I'll go a bit too fast and merge this (and the other PR). But happy to follow up and we should not stop doing that very soon or immediately if someone is unhappy about this :). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is useful for generic wrappers. I still wan to hold back to do all the work for them, but the information is rather readily available, so I think we can pass it on.
NumPy uses "relevant args" naming for the arguments we dispatch on, I decided to rename it to "dispatch" instead.
(Also changed to pass a tuple of types, because I think that is more future proof. We expect few types, a set isn't useful e.g. if done in C.)
cleaned up the tests slightly, to add a basic one for the context.