Skip to content

Simplify pullback of interpolation coordinates from facet in reference cell to reference facet #212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jorgensd merged 2 commits into from
May 16, 2026
Merged

Simplify pullback of interpolation coordinates from facet in reference cell to reference facet #212

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7c4b0a1
Simplify pullback of interpolation coordinates from facet in referenc…
jorgensd May 15, 2026
9eec6bf
Only need reference geom and topology for cell, ot the actual coordin…
jorgensd May 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 14 additions & 5 deletions src/scifem/bcs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,23 +34,32 @@ def interpolate_function_onto_facet_dofs(

interpolation_points = Q_el.basix_element.x

c_el = domain.ufl_domain().ufl_coordinate_element()
ref_top = c_el.reference_topology
ref_geom = c_el.reference_geometry
facet_types = set(basix.cell.subentity_types(domain.basix_cell())[fdim])
assert len(facet_types) == 1, "All facets must have the same topology"

# Pull back interpolation points from reference coordinate element to facet reference element
# We create affine versions of each of them as we are in reference mode.
# Then we avoid Newton convergence issues
ref_cmap = basix.ufl.element(
"Lagrange",
domain.basix_cell(),
1,
shape=(domain.topology.dim,),
dtype=np.float64,
)
ref_top = ref_cmap.reference_topology
ref_geom = ref_cmap.reference_geometry
facet_cmap = basix.ufl.element(
"Lagrange",
facet_types.pop(),
c_el.degree,
shape=(domain.geometry.dim,),
1,
shape=(domain.topology.dim,),
dtype=np.float64,
)
facet_cel = dolfinx.fem.CoordinateElement(
dolfinx.cpp.fem.CoordinateElement_float64(facet_cmap.basix_element._e)
)

reference_facet_points = None
for i, points in enumerate(interpolation_points[fdim]):
geom = ref_geom[ref_top[fdim][i]]
Expand Down
Loading