[ON_HOLD] Geodesic Flow Kernel#141
Open
antoinecollas wants to merge 10 commits intoscikit-adaptation:mainfrom
Open
[ON_HOLD] Geodesic Flow Kernel#141antoinecollas wants to merge 10 commits intoscikit-adaptation:mainfrom
antoinecollas wants to merge 10 commits intoscikit-adaptation:mainfrom
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #141 +/- ##
=======================================
Coverage 97.62% 97.63%
=======================================
Files 47 47
Lines 3924 3973 +49
=======================================
+ Hits 3831 3879 +48
- Misses 93 94 +1 |
Collaborator
|
@antoinecollas Do you think you can implement gsvd as you want? Or we cannot implement this method? |
Collaborator
Author
|
No, I tried but the gsvd of the paper is hard to implement in python right now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a WIP implementation of Geodesic Flow Kernel.
This method requires the Generalized SVD, and it is not implemented either in numpy or Scipy.
The
transferlearninglibrary usesbob.math.gsvdhere, which has its custom C++ code here.