[WIP] Beginners guide by mbarneche#301
[WIP] Beginners guide by mbarneche#301mbarneche wants to merge 21 commits intoscikit-adaptation:mainfrom
Conversation
changed conditional_shift to concept_drift so that the current skada version holds. Will be changed back as soon as the correct version gets out
| from skada.utils import extract_source_indices | ||
|
|
||
| # sphinx_gallery_start_ignore | ||
| fig_size = (8, 4) |
There was a problem hiding this comment.
Can you try to choose a fig_size to have squared plot ?
| ): | ||
| Xs, Xt, ys, yt = skada.source_target_split(X, y, sample_domain=sample_domain) | ||
|
|
||
| plt.subplot(1, 2, 1) |
There was a problem hiding this comment.
maybe here you can use set_box_aspect to have squared plot
| X, y, sd = make_shifted_datasets(20, 20, random_state=42) | ||
| Xs, Xt, ys, yt = skada.source_target_split(X, y, sample_domain=sd) | ||
|
|
||
| plt.subplot(4, 5, 1) |
There was a problem hiding this comment.
For the summary plot I would remove the first columns. And maybe just have one line for source, one line for target, one line for train without adaptation and one last line for training with adaptation
| T = T / T.max() | ||
|
|
||
| plt.figure(9) | ||
| plot_full_data(Xs, ys, "Mapping source (orange, blue) to target (yellow, purple)") |
There was a problem hiding this comment.
maybe you can change all the plot to have circle for source and square for target for example. The plot will be better without new color
There was a problem hiding this comment.
Do you mean changing this plot only or changing all the other plots as well ?
|
|
||
| clf = skada.TransferJointMatching(SVC(), n_components=1) | ||
| clf.fit(X, y, sample_domain=sample_domain) | ||
|
|
There was a problem hiding this comment.
I'm wondering if it is the best to put this plot here. Not sure
There was a problem hiding this comment.
The idea was that the reader would have a feel of what the projection looks like
| # | ||
| # Here is a summary of the different shifts and the domain adaptation methods used. | ||
|
|
||
| # sphinx_gallery_start_ignore |
|
What's the status of this PR? @mbarneche do you still need to do something? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #301 +/- ##
==========================================
- Coverage 96.64% 96.45% -0.19%
==========================================
Files 63 63
Lines 6910 6910
==========================================
- Hits 6678 6665 -13
- Misses 232 245 +13 🚀 New features to boost your workflow:
|
3 participants
Creation of a beginners guide for SKADA.
Small changes to the "how to" file so that it displays properly with sphinx.