Skip to content

Multi exp interface#42

Open
dtebbs wants to merge 2 commits into
scipr-lab:masterfrom
dtebbs:multi-exp-interface
Open

Multi exp interface#42
dtebbs wants to merge 2 commits into
scipr-lab:masterfrom
dtebbs:multi-exp-interface

Conversation

@dtebbs

@dtebbs dtebbs commented May 22, 2020

Copy link
Copy Markdown
Contributor

Exposed some more fine-grained scalar muliplication operations.

@madars

madars commented May 25, 2020

Copy link
Copy Markdown
Member

This looks good! We have a more generic interface for multi_exp, i.e. exposing the two iterators for vector start and end, rather than start + length. Maybe we can do the same here?

@dtebbs

dtebbs commented May 28, 2020

Copy link
Copy Markdown
Contributor Author

We have a more generic interface for multi_exp, i.e. exposing the two iterators for vector start and end, rather than start + length. Maybe we can do the same here?

Thanks for the comments @madars. Yes, the interface with iterators is better. I was originally concerned with keeping the change minimal, but iterators makes more sense - I'll do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants