Add wrapper to throw compiler warning for deprecated funcs#122
Open
jhiemstrawisc wants to merge 2 commits intoscitokens:masterfrom
Open
Add wrapper to throw compiler warning for deprecated funcs#122jhiemstrawisc wants to merge 2 commits intoscitokens:masterfrom
jhiemstrawisc wants to merge 2 commits intoscitokens:masterfrom
Conversation
In order to keep the `scitokens.h` header backwards compatible with older versions of C/C++ while still providing support for compiler warnings when a deprecated function is used, I set up a macro wrapper that checks for compiler support of the attribute and throws a warning when a deprecated function is used.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
djw8605
reviewed
Jun 6, 2023
Contributor
djw8605
left a comment
djw8605
left a comment
There was a problem hiding this comment.
Interesting, did you find this code somewhere?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to keep the
scitokens.hheader backwards compatible with older versions of C/C++ while still providing support for compiler warnings when a deprecated function is used, I set up a macro wrapper that checks for compiler support of the attribute and throws a warning when a deprecated function is used.I was aiming for broad compiler compatibility. Let me know if there's anything I can change.